Don't truncate commands + show running commands#1775
Don't truncate commands + show running commands#1775Minigamer42 wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:M
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ApprovabilityVerdict: Needs human review This PR introduces user-visible behavior changes: showing 'running' command status that was previously hidden, and displaying full command text instead of truncated versions. While the changes are well-scoped to display logic, they meaningfully alter what users see during tool execution and warrant human review. You can customize Macroscope's approvability policy. Learn more. |
Minigamer42
force-pushed
the
feature/preserve-runtime-tool-details
branch
from
b042087 to
941b722
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 941b722. Configure here.
- Stop truncating `detail` when ingesting provider runtime tool events
- carry item IDs and payload data through server ingestion - collapse tool lifecycle rows by stable item IDs - keep command start rows visible with clearer labels
Minigamer42
force-pushed
the
feature/preserve-runtime-tool-details
branch
from
941b722 to
74d4e79
Compare
1 participant
What Changed
truncateDetailcall for tool calls send by the agent (the output is still truncated via css ellipsis in the UI, but can be viewed by hovering)Why
UI Changes
https://www.youtube.com/watch?v=SJUpSWBkfUk
PS: Also works with the latest changes to not show the shell wrapper, this PR is unaffected by that.
Checklist
Note
Medium Risk
Changes the shape/handling of tool lifecycle activities (including emitting
itemIdand displayingtool.startedfor commands), which can affect work-log grouping and UI rendering but does not touch auth or persistence.Overview
Improves command/tool visibility in the chat work log. Tool lifecycle activities now carry through
itemId, andtool.startedevents forcommand_executionare no longer dropped so running commands can be shown with an in-progress label.Stops truncating
detailfortool.started/tool.completedactivities, and updates work-log collapsing to group lifecycle updates by a stablecollapseKey(preferringitemId, otherwise derived from item type + label + command/detail). The timeline UI also keys work-entry rows bycollapseKeywhen available to reduce row churn during updates.Reviewed by Cursor Bugbot for commit 941b722. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Show running commands in chat and stop truncating command detail
tool.startedevents forcommand_executionitems are now included in the work log (previously alltool.startedevents were filtered out), displaying a "Running command" title while in progress and "Ran command" on completion.detailpayloads are no longer truncated intool.startedandtool.completedactivities in ProviderRuntimeIngestion.ts.collapseKey(preferringitemId) across non-adjacent entries, replacing the previous immediate-predecessor-only approach.collapseKeyoverid, which may alter component reuse during updates.collapseKey, andtool.startedfor non-command items remains filtered out.Macroscope summarized 941b722.